[api-minor] Deprecate the imageLayer functionality
#15346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
force-pushed
the
deprecated-imageLayer
branch
3 times, most recently
from
bfa64ce to
27e367e
Compare
This old method, which is only used with the `imageLayer` functionality, is essentially just a re-implementation of the existing `Util.applyTransform` method.
This functionality has never been used anywhere in the PDF.js library/viewer itself, since it was added in 2013. Furthermore this functionality is, and has always been, *completely untested* and also unmaintained. Finally, there's (at least) one old issue about `appendImage` not returning the correct position; see issue 4182. All-in-all, it seems that keeping very old, untested, unmaintained, and partially broken code around probably isn't what we want here. (On the off-chance that any future a11y-work requires getting access to image-positions, it'd likely be much better to re-implement the necessary functionality from scratch and also make sure that it's properly tested from the beginning.)
Snuffleupagus
force-pushed
the
deprecated-imageLayer
branch
from
27e367e to
118da8e
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/fdfa717254a311a/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/dbcbf71a91948ae/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/fdfa717254a311a/output.txt Total script time: 4.95 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/dbcbf71a91948ae/output.txt Total script time: 9.50 mins
|
timvandermeij
approved these changes
Aug 27, 2022
|
Good idea to deprecate this now before the next minor and major releases. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This functionality has never been used anywhere in the PDF.js library/viewer itself, since it was added in 2013.
Furthermore this functionality is, and has always been, completely untested and also unmaintained.
Finally, there's (at least) one old issue about
appendImagenot returning the correct position; see issue #4182.All-in-all, it seems that keeping very old, untested, unmaintained, and partially broken code around probably isn't what we want here.
(On the off-chance that any future a11y-work requires getting access to image-positions, it'd likely be much better to re-implement the necessary functionality from scratch and also make sure that it's properly tested from the beginning.)