Remove the remaining closures in the src/core/cff_parser.js file
#15310
Conversation
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/f4c3932224a0335/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/15ab620a3b05304/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/f4c3932224a0335/output.txt Total script time: 26.83 mins
Image differences available at: http://54.241.84.105:8877/f4c3932224a0335/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/15ab620a3b05304/output.txt Total script time: 28.79 mins
Image differences available at: http://54.193.163.58:8877/15ab620a3b05304/reftest-analyzer.html#web=eq.log |
Given that the code is written with JavaScript module-syntax, none of this functionality will "leak" outside of this file with these changes. For e.g. the `gulp mozcentral` command the *built* `pdf.worker.js` file-size decreases `~2 kB` with this patch, and most of the improvement comes from having less overall indentation in the code.
Snuffleupagus
force-pushed
the
cff-parser-rm-closure
branch
from
8654f63 to
e5e756c
Compare
|
Fixed a typo in the commit message, no actual code changes were made. |
|
Thank you! |
Given that the code is written with JavaScript module-syntax, none of this functionality will "leak" outside of this file with these changes.
For e.g. the
gulp mozcentralcommand the builtpdf.worker.jsfile-size decreases~2 kBwith this patch, and most of the improvement comes from having less overall indentation in the code.