-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve text-selection for Type3 fonts with bogus /FontBBox-entries (issue 14999) #15133
Conversation
…issue 14999) This extends PR 13461, by also building a fallback bounding box for Type3 fonts that contain a much too small /FontBBox-entry. *Please note:* While this patch improves things overall, copy-and-pasting still doesn't work perfectly for this document. In particular the lowercase letter "c" cannot be selected/copied, however this can be reproduced in both Adobe Reader and PDFium (in Google Chrome) too, which is caused by a lack of proper /ToUnicode-data in the PDF document.
05fa303
to
79cfc54
Compare
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/4f88acb99f9a40e/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/cd798962c708916/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/4f88acb99f9a40e/output.txt Total script time: 25.99 mins
Image differences available at: http://54.241.84.105:8877/4f88acb99f9a40e/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/cd798962c708916/output.txt Total script time: 29.34 mins
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks reasonable. Thank you.
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/89b02068c3654e8/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.193.163.58:8877/c17e8a84c5b8277/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/89b02068c3654e8/output.txt Total script time: 23.13 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/c17e8a84c5b8277/output.txt Total script time: 22.94 mins
|
This extends PR #13461, by also building a fallback bounding box for Type3 fonts that contain a much too small /FontBBox-entry.
Please note: While this patch improves things overall, copy-and-pasting still doesn't work perfectly for this document. In particular the lowercase letter "c" cannot be selected/copied, however this can be reproduced in both Adobe Reader and PDFium (in Google Chrome) too, which is caused by a lack of proper /ToUnicode-data in the PDF document.