-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the Popup-trigger for FileAttachmentAnnotationElement
(PR 15036 follow-up)
#15125
Fix the Popup-trigger for FileAttachmentAnnotationElement
(PR 15036 follow-up)
#15125
Conversation
… follow-up) After the changes in PR 15036, the trigger-element created in `FileAttachmentAnnotationElement.render` is now too small. This can be fixed by using the same approach as in PR 15065, and the patch can be tested using the `annotation-fileattachment.pdf` document in the test-suite.
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/e8aa581daa6fb30/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/8c2490f81f2af4c/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/8c2490f81f2af4c/output.txt Total script time: 26.09 mins
Image differences available at: http://54.241.84.105:8877/8c2490f81f2af4c/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/e8aa581daa6fb30/output.txt Total script time: 28.22 mins
Image differences available at: http://54.193.163.58:8877/e8aa581daa6fb30/reftest-analyzer.html#web=eq.log |
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/752cb5fc3b4e445/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 2 Live output at: http://54.193.163.58:8877/0d375f0e12a8ed6/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/752cb5fc3b4e445/output.txt Total script time: 22.54 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/0d375f0e12a8ed6/output.txt Total script time: 22.62 mins
|
After the changes in PR #15036, the trigger-element created in
FileAttachmentAnnotationElement.render
is now too small. This can be fixed by using the same approach as in PR #15065, and the patch can be tested using theannotation-fileattachment.pdf
document in the test-suite.