Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Popup-trigger for FileAttachmentAnnotationElement (PR 15036 follow-up) #15125

Conversation

Snuffleupagus
Copy link
Collaborator

After the changes in PR #15036, the trigger-element created in FileAttachmentAnnotationElement.render is now too small. This can be fixed by using the same approach as in PR #15065, and the patch can be tested using the annotation-fileattachment.pdf document in the test-suite.

… follow-up)

After the changes in PR 15036, the trigger-element created in `FileAttachmentAnnotationElement.render` is now too small. This can be fixed by using the same approach as in PR 15065, and the patch can be tested using the `annotation-fileattachment.pdf` document in the test-suite.
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Jul 4, 2022

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/e8aa581daa6fb30/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 4, 2022

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/8c2490f81f2af4c/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 4, 2022

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/8c2490f81f2af4c/output.txt

Total script time: 26.09 mins

  • Font tests: Passed
  • Unit tests: FAILED
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 30

Image differences available at: http://54.241.84.105:8877/8c2490f81f2af4c/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Jul 4, 2022

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/e8aa581daa6fb30/output.txt

Total script time: 28.22 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 2

Image differences available at: http://54.193.163.58:8877/e8aa581daa6fb30/reftest-analyzer.html#web=eq.log

@Snuffleupagus Snuffleupagus merged commit ca8b112 into mozilla:master Jul 4, 2022
@Snuffleupagus
Copy link
Collaborator Author

/botio makeref

@pdfjsbot
Copy link

pdfjsbot commented Jul 4, 2022

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/752cb5fc3b4e445/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 4, 2022

From: Bot.io (Windows)


Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 2

Live output at: http://54.193.163.58:8877/0d375f0e12a8ed6/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 4, 2022

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/752cb5fc3b4e445/output.txt

Total script time: 22.54 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

pdfjsbot commented Jul 4, 2022

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/0d375f0e12a8ed6/output.txt

Total script time: 22.62 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@Snuffleupagus Snuffleupagus deleted the FileAttachmentAnnotationElement-trigger branch July 4, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants