[editor] Disable editing while PresentationMode is active

[Snuffleupagus]

No description provided.

[Snuffleupagus]

/botio-linux preview

[pdfjsbot]

From: Bot.io (Linux m4)

---

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/0d4496ca949fa51/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.241.84.105:8877/0d4496ca949fa51/output.txt

Total script time: 2.60 mins

Published

• Viewer: http://54.241.84.105:8877/0d4496ca949fa51/web/viewer.html
• Viewer (legacy): http://54.241.84.105:8877/0d4496ca949fa51/legacy/web/viewer.html

[Snuffleupagus]

/botio integrationtest

[pdfjsbot]

From: Bot.io (Linux m4)

---

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/e97bf197642268d/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/ef370e3f41c23a4/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.241.84.105:8877/e97bf197642268d/output.txt

Total script time: 4.65 mins

• Integration Tests: Passed

[pdfjsbot]

From: Bot.io (Windows)

---

Failed

Full output at http://54.193.163.58:8877/ef370e3f41c23a4/output.txt

Total script time: 7.80 mins

• Integration Tests: FAILED

[marco-c]

Might not be too bad to support it (e.g. if you're doing a presentation and you want to highlight some area of the presentation), but definitely requires a better UX.

[Snuffleupagus]

Might not be too bad to support it (e.g. if you're doing a presentation and you want to highlight some area of the presentation), but definitely requires a better UX.

Given that we purposely don't have any toolbars (or other UI) visible in PresentationMode, there'd be no way to e.g. change any of the editing-parameters without leaving PresentationMode first.
Furthermore, considering how PresentationMode is implemented there's bound to be a number of assumptions (in both the JS and CSS code) that basically depends on it being a very simple mode without e.g. any toolbars. Changing that would probably not be entirely simple, since there's going to be lots of edge-cases, which is why I think this patch makes sense here.

[marco-c]

Oh yes, it makes perfect sense to disable it for now. Mine was just an idea for a future feature :)

[Snuffleupagus]

Note that there's also the "browser fullscreen"-mode, which can be toggled with F11 (at least on Windows), that allows the regular PDF.js viewer (or any web-page really) to occupy the entire screen.

[calixteman]

LGTM.