Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove element ids from the layersView in the sidebar #15099

Merged
merged 1 commit into from
Jun 25, 2022

Conversation

Snuffleupagus
Copy link
Collaborator

Similar to other recent patches, see e.g. PR #15057, we don't want to add these kind of ids to DOM-elements since they shouldn't become "linkable" through the URL hash.

Please note: This patch can be tested, in the viewer, with e.g. bug1737260.pdf from the test-suite.

Similar to other recent patches, see e.g. PR 15057, we don't want to add these kind of `id`s to DOM-elements since they shouldn't become "linkable" through the URL hash.

*Please note:* This patch can be tested, in the viewer, with e.g. `bug1737260.pdf` from the test-suite.
@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/64a7d58047a50f7/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/64a7d58047a50f7/output.txt

Total script time: 2.60 mins

Published

@timvandermeij timvandermeij merged commit f93ab76 into mozilla:master Jun 25, 2022
@timvandermeij
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants