-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add (basic) support for Optional Content in Annotations #15095
Conversation
0e3a068
to
95170ae
Compare
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/2e560162e76dcb2/output.txt |
Given that Annotations can also have an `OC`-entry, we need to take that into account when generating their operatorLists. Note that in order to simplify the patch the `getOperatorList`-methods, for the Annotation-classes, were converted to be `async`.
95170ae
to
c48dc25
Compare
/botio-windows test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/b3a208ca60a1cb3/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/2e560162e76dcb2/output.txt Total script time: 26.17 mins
Image differences available at: http://54.241.84.105:8877/2e560162e76dcb2/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/b3a208ca60a1cb3/output.txt Total script time: 28.54 mins
Image differences available at: http://54.193.163.58:8877/b3a208ca60a1cb3/reftest-analyzer.html#web=eq.log |
I don't know that much about |
Perhaps not, unless it turns out to be at least a somewhat commonly requested feature.
I can only recall having seeing such a document once before, but of course I cannot find it right now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks reasonable.
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/a55ff5b6ff6e31f/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 2 Live output at: http://54.193.163.58:8877/5e89a3f2aa36f0f/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/a55ff5b6ff6e31f/output.txt Total script time: 22.91 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/5e89a3f2aa36f0f/output.txt Total script time: 22.13 mins
|
Given that Annotations can also have an
OC
-entry, we need to take that into account when generating their operatorLists.Note that in order to simplify the patch the
getOperatorList
-methods, for the Annotation-classes, were converted to beasync
.