Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (basic) support for Optional Content in Annotations #15095

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

Snuffleupagus
Copy link
Collaborator

@Snuffleupagus Snuffleupagus commented Jun 24, 2022

Given that Annotations can also have an OC-entry, we need to take that into account when generating their operatorLists.

Note that in order to simplify the patch the getOperatorList-methods, for the Annotation-classes, were converted to be async.

@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/2e560162e76dcb2/output.txt

Given that Annotations can also have an `OC`-entry, we need to take that into account when generating their operatorLists.

Note that in order to simplify the patch the `getOperatorList`-methods, for the Annotation-classes, were converted to be `async`.
@mozilla mozilla deleted a comment from pdfjsbot Jun 24, 2022
@mozilla mozilla deleted a comment from pdfjsbot Jun 24, 2022
@Snuffleupagus
Copy link
Collaborator Author

/botio-windows test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/b3a208ca60a1cb3/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/2e560162e76dcb2/output.txt

Total script time: 26.17 mins

  • Font tests: Passed
  • Unit tests: FAILED
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 27
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/2e560162e76dcb2/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/b3a208ca60a1cb3/output.txt

Total script time: 28.54 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.193.163.58:8877/b3a208ca60a1cb3/reftest-analyzer.html#web=eq.log

@calixteman
Copy link
Contributor

I don't know that much about OC stuff, so maybe my questions are meaningless.
In the JS api there is an OCG object which allows to show/hide the corresponding OC layer, do you think it's worth spending to implement it ?
Do you know if OCG are widely spread in Acroform to make them more "dynamic" ?
I noticed this pdf few days ago:
https://bugs.chromium.org/p/chromium/issues/attachment?aid=558169&signed_aid=fm0hxVYNIjr9UKjjmKmk3w==
which allows to change the content from thanks to OCG and JS.
Anyway it isn't directly related to this patch... so we can chat about that in a separate issue.

@Snuffleupagus
Copy link
Collaborator Author

Snuffleupagus commented Jun 24, 2022

In the JS api there is an OCG object which allows to show/hide the corresponding OC layer, do you think it's worth spending to implement it ?

Perhaps not, unless it turns out to be at least a somewhat commonly requested feature.

Do you know if OCG are widely spread in Acroform to make them more "dynamic" ?

I can only recall having seeing such a document once before, but of course I cannot find it right now.

Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks reasonable.

@Snuffleupagus Snuffleupagus merged commit cd35b9b into mozilla:master Jun 24, 2022
@Snuffleupagus
Copy link
Collaborator Author

/botio makeref

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/a55ff5b6ff6e31f/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 2

Live output at: http://54.193.163.58:8877/5e89a3f2aa36f0f/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/a55ff5b6ff6e31f/output.txt

Total script time: 22.91 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/5e89a3f2aa36f0f/output.txt

Total script time: 22.13 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants