-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly order added annotations when saving or printing #15089
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixing a bug by removing code is the best kind of patch :-)
r=me, with passing tests; thank you!
src/core/annotation.js
Outdated
const results = await Promise.all(promises); | ||
|
||
return { | ||
annotations: results, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the changes here, this could possibly be simplified even further now?
const results = await Promise.all(promises); | |
return { | |
annotations: results, | |
return { | |
annotations: await Promise.all(promises), |
- the annotations must be rendered in the same order as the chronological one. - fix a bug in document.js which avoids to read a saved pdf correctly in Acrobat: there is no need to reset the xref state: it's done in worker.js once everything has been saved.
683ce47
to
e49d039
Compare
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/85745c54004166d/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/f7561a9aa96d9f5/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/85745c54004166d/output.txt Total script time: 26.06 mins
Image differences available at: http://54.241.84.105:8877/85745c54004166d/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/f7561a9aa96d9f5/output.txt Total script time: 27.67 mins
Image differences available at: http://54.193.163.58:8877/f7561a9aa96d9f5/reftest-analyzer.html#web=eq.log |
there is no need to reset the xref state: it's done in worker.js once everything
has been saved.