Improve the PDFSidebar implementation
#14962
Conversation
With the exception of `isThumbnailViewVisible`, these getters are completely unused. Generally speaking, using the `visibleView`-getter directly works just as well and seems (at least to me) to be overall preferable considering how our classes are usually implemented.
…0502 follow-up) This removes the internal `_switchView`-method, since looking at all of this again it feels simpler to instead track the initial event dispatching.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/46ea49b29261f1d/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/46ea49b29261f1d/output.txt Total script time: 2.51 mins Published |
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/f656103e14054e0/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/bab967f18eb623c/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/f656103e14054e0/output.txt Total script time: 4.55 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/bab967f18eb623c/output.txt Total script time: 7.02 mins
|
Snuffleupagus
changed the title
PDFSidebar implementationPDFSidebar implementation
|
Thank you for doing this! |
Please refer to the individual commit messages for additional details.