Ignore pageColors when the background/foreground is identical (PR 14874 follow-up)
#14887
Conversation
Snuffleupagus
force-pushed
the
pageColors-followup
branch
from
a798e89 to
66bceed
Compare
…874 follow-up) Given that the new API-option is an Object named `pageColors`, with `background`/`foreground` keys, it occurred to me that it'd be slightly more consistent if the options/preferences names fully reflected that.
Snuffleupagus
force-pushed
the
pageColors-followup
branch
from
66bceed to
d8d7bc0
Compare
…4874 follow-up) If the computed background/foreground colors are identical, the `canvas` would be rendered mostly blank with only images visible. Hence it seems reasonable to also ignore the `pageColors`-option in this case. Also, the patch tries to *briefly* outline the various cases in which we ignore the `pageColors`-option in a comment.
Snuffleupagus
changed the title
pageColors when the background/foreground is identical (14874 follow-up)pageColors when the background/foreground is identical (PR 14874 follow-up)
Snuffleupagus
force-pushed
the
pageColors-followup
branch
from
d8d7bc0 to
472a1f9
Compare
I was trying to protect against the user manually specifying e.g. |
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/6f536a38ab70364/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/95511893920df7b/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/6f536a38ab70364/output.txt Total script time: 26.42 mins
Image differences available at: http://54.241.84.105:8877/6f536a38ab70364/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/95511893920df7b/output.txt Total script time: 31.28 mins
|
If the computed background/foreground colors are identical, the
canvaswould be rendered mostly blank with only images visible. Hence it seems reasonable to also ignore thepageColors-option in this case.Also, the patch tries to briefly outline the various cases in which we ignore the
pageColors-option in a comment.