-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update quickjs to revision 2788d71e823b522b178db3b3660ce93689534e6d #14863
Conversation
calixteman
commented
May 1, 2022
- The date parser in quickjs is not optimal so use the navigator one.
- The date parser in quickjs is not optimal so use the navigator one.
I noticed some errors with date parsing so I patched our quickjs built to use the navigator date parser: |
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/9669980863161a2/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/2917d944f2e8224/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/9669980863161a2/output.txt Total script time: 3.52 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/2917d944f2e8224/output.txt Total script time: 6.61 mins
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/9b1fb76e50e1057/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/735a9ebf9152ddd/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/9b1fb76e50e1057/output.txt Total script time: 4.32 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/735a9ebf9152ddd/output.txt Total script time: 7.66 mins
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me (essentially rubber-stamping the changes).
However, there's a couple of alerts here: https://github.com/mozilla/pdf.js/pull/14863/checks?check_run_id=6247493331
Are some of those possible to fix, perhaps by patching/updating the build-process in https://github.com/mozilla/pdf.js.quickjs, or should we simply just ignore them?
I don't know what to do to remove these warnings. If you've any ideas, then I take, else I think we should ignore them. |
Given that the alerts don't suggest any security problems, but rather just mention unused code and missing semicolons, it's likely not meaningful to spend a lot of time/effort on "fixing" this (especially when none of this code is being used in Firefox). |