Improve performance of shared/utils.js::intersect (bug 1135277) #14784
Conversation
marco-c
changed the title
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/2720d3a4b27359c/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/53d3b527f45c211/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/2720d3a4b27359c/output.txt Total script time: 25.29 mins
Image differences available at: http://54.241.84.105:8877/2720d3a4b27359c/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/53d3b527f45c211/output.txt Total script time: 26.60 mins
|
src/shared/util.js
Outdated
| // [a, b] inter [c d] != 0 <=> c <= b && d >= a | ||
| // [a, b] inter [c d] = [max(a, c), min(b, d)] with max <= min. |
There was a problem hiding this comment.
It might just be a question about the formatting here, but I'm sorry to say that I'm actually finding this comment slightly less clear than just carefully reading the code directly :-)
- avoid to call normalizeRect which clones the rectangles: it's useless and time consuming; - in profiling the pdf in bug 1135277, the time spent in intersect drops from ~1s to ~30ms.
and time consuming;
from ~1s to ~30ms.