Remove the BaseViewer._getCurrentVisiblePage helper method
#14750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method was originally added specifically to work-around bugs/issues related to PresentationMode in Google Chrome. Note that prior to PR 14112 we were using some CSS hacks to only show the current page in PresentationMode, and that could lead to the `getVisibleElements` function not always finding the correct elements. However, after the changes in PR 14112 we're now using the Page-scrolling mode in PresentationMode and consequently there'll only be *a single* page visible at a time. Hence then `BaseViewer._getCurrentVisiblePage` helper method should no longer be needed, and when testing (locally) in Google Chrome everything seems to work correctly now.
…n PresentationMode The `pdfOpenParams` parameter has never really made sense in PresentationMode, since e.g. the zoom-value doesn't (generally) agree with the value chosen by the user prior to entering PresentationMode. This has never mattered all that much, since the `viewBookmark`-button isn't visible in PresentationMode (nor is any other toolbar button for that matter). However, in the `PDFHistory`-implementation we're currently forced to handle this case specifically since we don't want to populate the browser history with nonsensical state. Hence it makes overall sense, as far as I'm concerned, to tweak the "updateviewarea" event to include a *simplified* `pdfOpenParams` parameter when PresentationMode is active. Given that the `viewer components` don't include PresentationMode functionality, this change thus shouldn't matter for third-party users.
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/4422c2a1ab9e1bc/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/ff83522938d5c48/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/4422c2a1ab9e1bc/output.txt Total script time: 4.01 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/ff83522938d5c48/output.txt Total script time: 6.96 mins
|
timvandermeij
approved these changes
Apr 8, 2022
|
Makes sense; nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
BaseViewer._getCurrentVisiblePagehelper methodThis method was originally added specifically to work-around bugs/issues related to PresentationMode in Google Chrome. Note that prior to PR Add a new Page scrolling mode (issue 2638, 8952, 10907) #14112 we were using some CSS hacks to only show the current page in PresentationMode, and that could lead to the
getVisibleElementsfunction not always finding the correct elements.However, after the changes in PR Add a new Page scrolling mode (issue 2638, 8952, 10907) #14112 we're now using the Page-scrolling mode in PresentationMode and consequently there'll only be a single page visible at a time. Hence then
BaseViewer._getCurrentVisiblePagehelper method should no longer be needed, and when testing (locally) in Google Chrome everything seems to work correctly now.Tweak the
pdfOpenParamsparameter, in the "updateviewarea" event, in PresentationModeThe
pdfOpenParamsparameter has never really made sense in PresentationMode, since e.g. the zoom-value doesn't (generally) agree with the value chosen by the user prior to entering PresentationMode.This has never mattered all that much, since the
viewBookmark-button isn't visible in PresentationMode (nor is any other toolbar button for that matter). However, in thePDFHistory-implementation we're currently forced to handle this case specifically since we don't want to populate the browser history with nonsensical state.Hence it makes overall sense, as far as I'm concerned, to tweak the "updateviewarea" event to include a simplified
pdfOpenParamsparameter when PresentationMode is active. Given that theviewer componentsdon't include PresentationMode functionality, this change thus shouldn't matter for third-party users.