Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the custom grab/grabbing cursor image files #14676

Merged
merged 2 commits into from
Mar 16, 2022

Conversation

Snuffleupagus
Copy link
Collaborator

  • [gulpfile.js] Remove the cleanup parameter in preprocessCSS helper function

    Every single call-site has always passed in true for this parameter, ever since the function was first added back in PR Moves preprocessor stuff to the gulpfile. #8023. Hence the parameter appears to be completely unnecessary, which is why it's removed and the function is updated to unconditionally strip out any license headers (in the middle of the file).

  • Remove the custom grab/grabbing cursor image files

    According to the MDN compatibility data, see https://developer.mozilla.org/en-US/docs/Web/CSS/cursor#browser_compatibility, all browsers that we now support should have these cursors available natively.

…r function

Every single call-site has always passed in `true` for this parameter, ever since the function was first added back in PR 8023. Hence the parameter appears to be completely unnecessary, which is why it's removed and the function is updated to *unconditionally* strip out any license headers (in the middle of the file).
According to the MDN compatibility data, see https://developer.mozilla.org/en-US/docs/Web/CSS/cursor#browser_compatibility, all browsers that we now support should have these cursors available natively.
@mozilla mozilla deleted a comment from pdfjsbot Mar 15, 2022
@mozilla mozilla deleted a comment from pdfjsbot Mar 15, 2022
@mozilla mozilla deleted a comment from pdfjsbot Mar 15, 2022
@mozilla mozilla deleted a comment from pdfjsbot Mar 15, 2022
@timvandermeij timvandermeij merged commit 82770e0 into mozilla:master Mar 16, 2022
@timvandermeij
Copy link
Contributor

Thanks for the cleanup!

@Snuffleupagus Snuffleupagus deleted the preprocessCSS-cleanup branch March 16, 2022 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants