Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use BaseViewer.previousPage more in the default viewer (PR 12870 follow-up) #14221

Merged
merged 2 commits into from
Nov 3, 2021

Conversation

Snuffleupagus
Copy link
Collaborator

I missed this one spot in PR #12870, when converting the other cases in the "keydown" event handler. However, given that it only matters in PresentationMode and/or when "page-fit" zooming is enabled, this oversight shouldn't have had any user-observable impact (but we should fix it nonetheless).

…llow-up)

I missed this one spot in PR 12870, when converting the other cases in the "keydown" event handler. However, given that it only matters in PresentationMode and/or when "page-fit" zooming is enabled, this oversight shouldn't have had any user-observable impact (but we should fix it nonetheless).
…es in various event handlers

This way we no longer need the intermediate variables.
@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Nov 2, 2021

From: Bot.io (Linux m4)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/9b29356e6efa82c/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Nov 2, 2021

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/9b29356e6efa82c/output.txt

Total script time: 4.24 mins

Published

@timvandermeij timvandermeij merged commit c68dc03 into mozilla:master Nov 3, 2021
@timvandermeij
Copy link
Contributor

Looks good!

@Snuffleupagus Snuffleupagus deleted the pr-12870-followup branch November 3, 2021 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants