Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XFA - A field without an ui must provide a default one (bug 1718245) #13778

Merged
merged 1 commit into from
Jul 22, 2021
Merged

XFA - A field without an ui must provide a default one (bug 1718245) #13778

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 32 additions & 1 deletion src/core/xfa/template.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2548,6 +2548,37 @@ class Field extends XFAObject {
}

[$toHTML](availableSpace) {
if (!this.ui) {
// It's allowed to not have an ui, specs say:
// If the UI element contains no children or is not present,
// the application chooses a default user interface for the
// container, based on the type of the container's content.

this.ui = new Ui({});
this.ui[$globalData] = this[$globalData];
this[$appendChild](this.ui);
let node;

// The items element can have 2 element max and
// according to the items specs it's likely a good
// way to guess the correct ui type.
switch (this.items.children.length) {
case 0:
calixteman marked this conversation as resolved.
Show resolved Hide resolved
node = new TextEdit({});
this.ui.textEdit = node;
break;
case 1:
node = new CheckButton({});
this.ui.checkButton = node;
break;
case 2:
node = new ChoiceList({});
this.ui.choiceList = node;
break;
}
this.ui[$appendChild](node);
}

setTabIndex(this);

if (
Expand Down Expand Up @@ -2689,7 +2720,7 @@ class Field extends XFAObject {
const borderStyle = this.border ? this.border[$toStyle]() : null;

const bbox = computeBbox(this, html, availableSpace);
const ui = this.ui ? this.ui[$toHTML]().html : null;
const ui = this.ui[$toHTML]().html;
if (!ui) {
Object.assign(style, borderStyle);
return HTMLResult.success(createWrapper(this, html), bbox);
Expand Down