XFA - Keep xfa layer on top of the others (bug 1719629) #13706
Conversation
| if (this.xfaLayer?.div) { | ||
| // The xfa layer needs to stay on top. | ||
| div.appendChild(this.xfaLayer.div); | ||
| } |
There was a problem hiding this comment.
If I'd actually been given a chance to review this before it landed, I'd have suggested to move this block and place it around line 513 instead rather than here since that'd seem generally "safer"!
With this patch, you're not actually guaranteed a correct placement (i.e. on top) of the XFALayer in the DOM in the event that the textLayer is disabled. This probably won't matter in practice, since I'm hoping that XFA documents don't contain a separate AnnotationLayer (although how knows with XFA Foreground documents).
(Since as was asked for review this, and the patch was opened a mere two hours ago, I guess that I don't really understand the big rush here!?)
There was a problem hiding this comment.
(Since as was asked for review this, and the patch was opened a mere two hours ago, I guess that I don't really understand the big rush here!?)
We're trying to land as many XFA fixes as possible as we hope to enable XFA in Firefox 91.
XFA - Move xfa layer on top of the others (follow-up of #13706)
No description provided.