Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XFA - Default background in rectangle is white #13684

Merged
merged 1 commit into from
Jul 6, 2021
Merged

XFA - Default background in rectangle is white #13684

merged 1 commit into from
Jul 6, 2021

Conversation

calixteman
Copy link
Contributor

@calixteman
Copy link
Contributor Author

It's expected to have a lot of regressions in reftests but overall borders are a way better rendered thanks to this patch.

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Jul 6, 2021

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 1

Live output at: http://54.67.70.0:8877/ca15464b398393b/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 6, 2021

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 1

Live output at: http://3.101.106.178:8877/ae52640793050a8/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 6, 2021

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/ca15464b398393b/output.txt

Total script time: 31.95 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 351
  different first/second rendering: 1

Image differences available at: http://54.67.70.0:8877/ca15464b398393b/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Jul 6, 2021

From: Bot.io (Windows)

Failed

Full output at http://3.101.106.178:8877/ae52640793050a8/output.txt

Total script time: 36.50 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 349
  different first/second rendering: 1

Image differences available at: http://3.101.106.178:8877/ae52640793050a8/reftest-analyzer.html#web=eq.log

@marco-c
Copy link
Contributor

marco-c commented Jul 6, 2021

The PDF from #13634 is better than before (more rectangles are white), but there are still some rectangles that should be white but aren't.

@brendandahl
Copy link
Contributor

It looks like xfa_issue13213 has some content that is now missing. Is this expected?

@marco-c
Copy link
Contributor

marco-c commented Jul 6, 2021

It looks like xfa_issue13213 has some content that is now missing. Is this expected?

Ooh, I had missed that, too many pages!

@calixteman
Copy link
Contributor Author

calixteman commented Jul 6, 2021 •
edited
Loading

There is an error on page 4 of xfa_issue13213 but for the others it is expected: depending of the value of a checkbox these white rectangles on top of form elements are hidden or not.

@calixteman
XFA - Default background in rectangle is white
c47f0f0 
  - Fix a typo in order to open the pdf in issue mozilla#13679
  - After fixing the fill default color there wer some regressions because of z-index
    and when fixing z-index there were some regressions because of borders
  - So fix the borders rendering.
@calixteman
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Jul 6, 2021

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/e6122e27b88e2a3/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 6, 2021

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://3.101.106.178:8877/b51e7e8393e67bd/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 6, 2021

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/e6122e27b88e2a3/output.txt

Total script time: 31.88 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 364
  different first/second rendering: 1

Image differences available at: http://54.67.70.0:8877/e6122e27b88e2a3/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Jul 6, 2021

From: Bot.io (Windows)

Failed

Full output at http://3.101.106.178:8877/b51e7e8393e67bd/output.txt

Total script time: 36.62 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 364

Image differences available at: http://3.101.106.178:8877/b51e7e8393e67bd/reftest-analyzer.html#web=eq.log

@brendandahl
Copy link
Contributor

I noticed one more xfa_bug1718740-page13. Though the button is in the wrong place to start, so I'm not sure that's a regression.

@brendandahl
Copy link
Contributor

/botio makeref

@pdfjsbot
Copy link

pdfjsbot commented Jul 6, 2021

From: Bot.io (Windows)

Received

Command cmd_makeref from @brendandahl received. Current queue size: 0

Live output at: http://3.101.106.178:8877/fe3fc6cbc9225b9/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 6, 2021

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @brendandahl received. Current queue size: 0

Live output at: http://54.67.70.0:8877/5851f4263203e63/output.txt

@brendandahl brendandahl merged commit a0aff12 into mozilla:master Jul 6, 2021
@pdfjsbot
Copy link

pdfjsbot commented Jul 6, 2021

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/5851f4263203e63/output.txt

Total script time: 28.64 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

pdfjsbot commented Jul 6, 2021

From: Bot.io (Windows)

Success

Full output at http://3.101.106.178:8877/fe3fc6cbc9225b9/output.txt

Total script time: 34.17 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@marco-c marco-c mentioned this pull request Jul 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-c marco-c marco-c approved these changes

Assignees
No one assigned
Labels
form-xfa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@calixteman @pdfjsbot @marco-c @brendandahl @timvandermeij