Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PDFs from #1773 to the reftests #13616

Merged
merged 1 commit into from
Jun 29, 2021
Merged

Conversation

marco-c
Copy link
Contributor

@marco-c marco-c commented Jun 23, 2021

No description provided.

@marco-c marco-c requested a review from calixteman June 23, 2021 10:59
@marco-c marco-c linked an issue Jun 23, 2021 that may be closed by this pull request
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are both of these new test-cases actually checking specific things not already covered by existing tests?

test/pdfs/MBTA-pretax-form-July2012.pdf.link Outdated Show resolved Hide resolved
test/pdfs/xfa_imm5257e.pdf.link Outdated Show resolved Hide resolved
@marco-c marco-c force-pushed the 1773_reftests branch 3 times, most recently from 734ce62 to 810dfd4 Compare June 23, 2021 12:06
@marco-c
Copy link
Contributor Author

marco-c commented Jun 23, 2021

Are both of these new test-cases actually checking specific things not already covered by existing tests?

There is no easy way to tell without code coverage information, but since we still have relatively few reftests for XFA, I'm inclined to think these are likely to cover at least something that isn't already covered.

@calixteman
Copy link
Contributor

And layout stuff is pretty touchy so having more reftests will help to avoid future layout regressions.

@calixteman calixteman merged commit d88d9a2 into mozilla:master Jun 29, 2021
@calixteman
Copy link
Contributor

/botio makeref

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/eae917b573338d2/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_makeref from @calixteman received. Current queue size: 1

Live output at: http://3.101.106.178:8877/8d5486593d2a0cb/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/eae917b573338d2/output.txt

Total script time: 26.36 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://3.101.106.178:8877/8d5486593d2a0cb/output.txt

Total script time: 31.44 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@marco-c marco-c deleted the 1773_reftests branch June 29, 2021 16:43
@timvandermeij timvandermeij removed the request for review from calixteman June 29, 2021 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PDF doesn't display anything, complains about my pdf viewer
5 participants