Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix find highlighting regression from #13306. #13478

Merged
merged 1 commit into from
Jun 4, 2021

Conversation

brendandahl
Copy link
Contributor

When we insert extra spans for highlighting we want
them to be positioned normally instead of absolute or
relative.

Fixes #13345.

When we insert extra spans for highlighting we want
them to be positioned normally instead of absolute or
relative.

Fixes mozilla#13345.
@brendandahl
Copy link
Contributor Author

The highlight still looks a bit wonky, but for this somewhat rare case I think it's okay.
image

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add an integration-test for this, similar to the existing one in find_spec.js, to avoid it regressing again?

r=me, thank you for fixing this!

@Snuffleupagus
Copy link
Collaborator

We can always land tests later, however I'm going to land this as-is (with passing tests) just so that the regression is fixed sooner rather than later.

/botio integrationtest

@pdfjsbot
Copy link

pdfjsbot commented Jun 4, 2021

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/007be12de8bfad4/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jun 4, 2021

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://3.101.106.178:8877/84d221f540ac0e4/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jun 4, 2021

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/007be12de8bfad4/output.txt

Total script time: 4.34 mins

  • Integration Tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Jun 4, 2021

From: Bot.io (Windows)


Success

Full output at http://3.101.106.178:8877/84d221f540ac0e4/output.txt

Total script time: 7.29 mins

  • Integration Tests: Passed

@Snuffleupagus Snuffleupagus merged commit 3b502f7 into mozilla:master Jun 4, 2021
@marco-c marco-c mentioned this pull request Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Regression] Highlighting of search results broken in some cases, after PR 13306
3 participants