Convert the src/core/{jbig2, jpg, jpx}.js files to use standard classes
#13338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes were made automatically, using `gulp lint --fix`.
…tically, in the `src/core/jbig2.js` file
*Please note:* Ignoring whitespace-only changes is probably necessary in order to review this.
These changes were made automatically, using `gulp lint --fix`.
…tically, in the `src/core/jpg.js` file
*Please note:* Ignoring whitespace-only changes is probably necessary in order to review this.
These changes were made automatically, using `gulp lint --fix`.
…tically, in the `src/core/jpx.js` file
*Please note:* Ignoring whitespace-only changes is probably necessary in order to review this.
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/ae9cfa57ffd7941/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/5bcb1af72a6b309/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/5bcb1af72a6b309/output.txt Total script time: 25.77 mins
Image differences available at: http://54.67.70.0:8877/5bcb1af72a6b309/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/ae9cfa57ffd7941/output.txt Total script time: 29.56 mins
Image differences available at: http://3.101.106.178:8877/ae9cfa57ffd7941/reftest-analyzer.html#web=eq.log |
timvandermeij
approved these changes
May 7, 2021
|
Looks much better; thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For e.g.
gulp mozcentral, the builtpdf.worker.jsfile decreases from1 621 424to1 610 798bytes with this patch-series.This is mostly the result of removing a few huge closures from the source files, since that removes a lot of unnecessary whitespace.