Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement high contrast mode #13203

Merged
merged 1 commit into from
Apr 12, 2021
Merged

Conversation

sawanm9000
Copy link

Fixes issue #13109.

PDF.js_High_Contrast_Mode.mp4

web/viewer.css Outdated Show resolved Hide resolved
web/viewer.css Outdated Show resolved Hide resolved
web/viewer.css Outdated Show resolved Hide resolved
web/viewer.css Outdated Show resolved Hide resolved
web/viewer.css Outdated Show resolved Hide resolved
web/viewer.css Outdated Show resolved Hide resolved
@sawanm9000 sawanm9000 force-pushed the high_contrast branch 2 times, most recently from e8a8ab2 to eddc02c Compare April 8, 2021 18:43
@sawanm9000
Copy link
Author

/botio-linux preview

1 similar comment
@brendandahl
Copy link
Contributor

/botio-linux preview

web/viewer.css Outdated Show resolved Hide resolved
web/viewer.css Outdated Show resolved Hide resolved
@sawanm9000 sawanm9000 marked this pull request as draft April 10, 2021 10:34
@sawanm9000 sawanm9000 marked this pull request as ready for review April 10, 2021 11:31
@sawanm9000 sawanm9000 force-pushed the high_contrast branch 3 times, most recently from 895c014 to c2db5fe Compare April 10, 2021 12:03
@mozilla mozilla deleted a comment from pdfjsbot Apr 10, 2021
@mozilla mozilla deleted a comment from pdfjsbot Apr 10, 2021
@timvandermeij
Copy link
Contributor

/botio-linux preview

web/viewer.css Outdated Show resolved Hide resolved
@mozilla mozilla deleted a comment from pdfjsbot Apr 11, 2021
@mozilla mozilla deleted a comment from pdfjsbot Apr 11, 2021
@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/19158c29b064f14/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/19158c29b064f14/output.txt

Total script time: 4.43 mins

Published

@brendandahl
Copy link
Contributor

@Snuffleupagus or @timvandermeij is this good to go? I'm hoping to do a mozilla-central update soon.

@Snuffleupagus
Copy link
Collaborator

@Snuffleupagus or @timvandermeij is this good to go? I'm hoping to do a mozilla-central update soon.

Please note: I've not really tested the forced-colors part of the patch, and instead focused on ensuring that this doesn't break/regress the "normal" light/dark themes.
The latest preview addresses all my previous comments, and as far as I'm concerned it's good to to go now :-)

@brendandahl As far as I understand, you need to manually set layout.css.forced-colors.enabled = true in about:config in order for this patch to actually have an effect!?
Is that preference going to be toggled on for all Firefox users? If not, can we special-case it (on the mozilla-central side) to apply to code running at resource://pdf.js/web/viewer.html?

@brendandahl
Copy link
Contributor

Is that preference going to be toggled on for all Firefox users? If not, can we special-case it (on the mozilla-central side) to apply to code running at resource://pdf.js/web/viewer.html?

It will soon on by default https://groups.google.com/g/mozilla.dev.platform/c/zwDaj0JMYjs

@brendandahl brendandahl merged commit 6cf3070 into mozilla:master Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants