[api-minor] Change the format of the fontName-property, in defaultAppearanceData, on Annotation-instances (PR 12831 follow-up)

[Snuffleupagus]

Currently the fontName-property contains an actual /Name-instance, which is a problem given that its fallback value is an empty string; see

pdf.js/src/core/default_appearance.js

Line 35 in ca7f546

fontName: Name.get(""),

The reason that this is a problem can be seen in

pdf.js/src/core/primitives.js

Lines 30 to 34 in ca7f546

	Name.get = function Name_get(name) {
	const nameValue = nameCache[name];
	// eslint-disable-next-line no-restricted-syntax
	return nameValue ? nameValue : (nameCache[name] = new Name(name));
	};

, since an empty string short-circuits the cache. Essentially, in PDF documents, a /Name-instance cannot be empty and the way that the DefaultAppearanceEvaluator does things is unfortunately not entirely correct.

Hence the fontName-property is changed to instead contain a string, rather than a /Name-instance, which simplifies the code overall.

Please note: I'm tagging this patch with "[api-minor]", since PR #12831 is included in the current pre-release (although we're not using the fontName-property in the display-layer).

[Snuffleupagus]

/botio test

[pdfjsbot]

From: Bot.io (Linux m4)

---

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/ed3e8249e78d5d3/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://3.101.106.178:8877/59c2f3a8c89eac8/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Failed

Full output at http://54.67.70.0:8877/ed3e8249e78d5d3/output.txt

Total script time: 24.96 mins

• Font tests: Passed
• Unit tests: Passed
• Integration Tests: FAILED
• Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/ed3e8249e78d5d3/reftest-analyzer.html#web=eq.log

[pdfjsbot]

From: Bot.io (Windows)

---

Failed

Full output at http://3.101.106.178:8877/59c2f3a8c89eac8/output.txt

Total script time: 29.75 mins

• Font tests: Passed
• Unit tests: Passed
• Integration Tests: FAILED
• Regression tests: FAILED

Image differences available at: http://3.101.106.178:8877/59c2f3a8c89eac8/reftest-analyzer.html#web=eq.log

[Snuffleupagus]

/botio integrationtest

[pdfjsbot]

From: Bot.io (Linux m4)

---

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/03bf87aef8d645a/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://3.101.106.178:8877/9ccf795ba7b10c1/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Failed

Full output at http://54.67.70.0:8877/03bf87aef8d645a/output.txt

Total script time: 3.99 mins

• Integration Tests: FAILED

[pdfjsbot]

From: Bot.io (Windows)

---

Success

Full output at http://3.101.106.178:8877/9ccf795ba7b10c1/output.txt

Total script time: 5.07 mins

• Integration Tests: Passed

[timvandermeij]

Thanks!