-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the URL
polyfill
#13158
Remove the URL
polyfill
#13158
Conversation
Based on this compatibility information, given that IE 11 is now *explicitly* unsupported, we should no longer need to bundle a `URL` polyfill in any builds: https://developer.mozilla.org/en-US/docs/Web/API/URL/URL#browser_compatibility Note that the caveat listed for older Safari-versions doesn't apply to any code in the PDF.js library, since we never call `new URL(url, undefined)` in the code-base. Note also that Node.js has a web-compatible `URL` implementation, which according to the "History" section at https://nodejs.org/api/url.html#url_the_whatwg_url_api has been available since Node.js `10.0.0` (according to https://nodejs.org/en/about/releases/ that branch is one month away from being EOL-ed).
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/02afcc12b242a78/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/fefdec5dae6341c/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/02afcc12b242a78/output.txt Total script time: 3.73 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/fefdec5dae6341c/output.txt Total script time: 6.03 mins
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/261402272d958ff/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/85cacdc5a5d25c9/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/261402272d958ff/output.txt Total script time: 24.72 mins
Image differences available at: http://54.67.70.0:8877/261402272d958ff/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/85cacdc5a5d25c9/output.txt Total script time: 28.76 mins
Image differences available at: http://3.101.106.178:8877/85cacdc5a5d25c9/reftest-analyzer.html#web=eq.log |
Nice to be able to get rid of this now; thanks! |
Based on this compatibility information, given that IE 11 is now explicitly unsupported, we should no longer need to bundle a
URL
polyfill in any builds: https://developer.mozilla.org/en-US/docs/Web/API/URL/URL#browser_compatibilityNote that the caveat listed for older Safari-versions doesn't apply to any code in the PDF.js library, since we never call
new URL(url, undefined)
in the code-base.Note also that Node.js has a web-compatible
URL
implementation, which according to the "History" section at https://nodejs.org/api/url.html#url_the_whatwg_url_api has been available since Node.js10.0.0
(according to https://nodejs.org/en/about/releases/ that branch is one month away from being EOL-ed).