Move rotation normalization from PDFViewerApplication and into BaseViewer
#13155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eViewer` The rotation handling that's currently living in `PDFViewerApplication` is *very* old, and pre-dates the introduction of the viewer components by years. As can be seen in the `BaseViewer.pagesRotation` setter, we're not actually normalizing the rotation as intended and instead rely on the caller to handle that correctly. This is first of all inconsistent, given how other setters are implemented, and secondly it could also lead to the rotation being set to a value outside of the `[0, 360)`-range. Finally, for improved consistency the rotation handling in `PageViewport` is updated similarly. Please note that this case, it's *not* changing the pre-existing logic.
Snuffleupagus
force-pushed
the
rotation-normalization
branch
from
246be15 to
19c2dfb
Compare
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/a526f4013087dbe/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/346f1ca66fa3cfa/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/a526f4013087dbe/output.txt Total script time: 3.75 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/346f1ca66fa3cfa/output.txt Total script time: 5.31 mins
|
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/a60baf954af4d2a/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/a60baf954af4d2a/output.txt Total script time: 4.33 mins Published |
timvandermeij
approved these changes
Mar 28, 2021
|
Nice find; thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rotation handling that's currently living in
PDFViewerApplicationis very old, and pre-dates the introduction of the viewer components by years.As can be seen in the
BaseViewer.pagesRotationsetter, we're not actually normalizing the rotation as intended and instead rely on the caller to handle that correctly. This is first of all inconsistent, given how other setters are implemented, and secondly it could also lead to the rotation being set to a value outside of the[0, 360)-range.Finally, for improved consistency the rotation handling in
PageViewportis updated similarly. Please note that this case, it's not changing the pre-existing logic.