-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support LineAnnotation
s with empty /Rect-entries (issue 6564)
#13106
Support LineAnnotation
s with empty /Rect-entries (issue 6564)
#13106
Conversation
This extends PR 13033 slightly, with a heuristic to support corrupt PDF documents where the `LineAnnotation`s have an empty /Rect-entry. Please note that while I have no idea if this is "correct", this patch at least makes us output the same /BBox as re-saving in Adobe Reader does.
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/655d2495ec98cd0/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/bac0d781b316890/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/655d2495ec98cd0/output.txt Total script time: 23.81 mins
Image differences available at: http://54.67.70.0:8877/655d2495ec98cd0/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/bac0d781b316890/output.txt Total script time: 28.86 mins
Image differences available at: http://3.101.106.178:8877/bac0d781b316890/reftest-analyzer.html#web=eq.log |
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/f273c05dd356baa/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/f273c05dd356baa/output.txt Total script time: 4.13 mins Published |
Thank you for improving this! /botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/51f7b7558e9d188/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://3.101.106.178:8877/d2f5a61f2129d77/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/51f7b7558e9d188/output.txt Total script time: 21.96 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/d2f5a61f2129d77/output.txt Total script time: 26.93 mins
|
This extends PR #13033 slightly, with a heuristic to support corrupt PDF documents where the
LineAnnotation
s have an empty /Rect-entry. Please note that while I have no idea if this is "correct", this patch at least makes us output the same /BBox as re-saving in Adobe Reader does.