-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable intermittent unit test "creates pdf doc from non-existent URL" #13078
Conversation
Filed #13077 to re-enable at some point. |
667bb68
to
f22a7ac
Compare
test/unit/api_spec.js
Outdated
}); | ||
}); | ||
// TODO: re-enable https://github.com/mozilla/pdf.js/issues/13077 | ||
// it("creates pdf doc from non-existent URL", function (done) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that this doesn't seem to fail when the tests are run with Github Actions, can't we keep this enabled conditionally instead of just commenting it out?
Something along these lines instead:
if (!isNodeJS) {
pending(...);
}
Disable this test so we don't have to manually review unit test failure log all the time.
f22a7ac
to
47a5550
Compare
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/44f14aee8c3ad9b/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/71137b5ece5b049/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/44f14aee8c3ad9b/output.txt Total script time: 3.63 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/71137b5ece5b049/output.txt Total script time: 5.78 mins
|
Disable this test so we don't have to manually review unit test
failure log all the time.