Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable intermittent unit test "creates pdf doc from non-existent URL" #13078

Merged
merged 1 commit into from
Mar 12, 2021

Conversation

brendandahl
Copy link
Contributor

Disable this test so we don't have to manually review unit test
failure log all the time.

@brendandahl
Copy link
Contributor Author

Filed #13077 to re-enable at some point.

});
});
// TODO: re-enable https://github.com/mozilla/pdf.js/issues/13077
// it("creates pdf doc from non-existent URL", function (done) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this doesn't seem to fail when the tests are run with Github Actions, can't we keep this enabled conditionally instead of just commenting it out?

Something along these lines instead:

if (!isNodeJS) {
  pending(...);
}

Disable this test so we don't have to manually review unit test
failure log all the time.
@Snuffleupagus
Copy link
Collaborator

/botio unittest

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/44f14aee8c3ad9b/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://3.101.106.178:8877/71137b5ece5b049/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/44f14aee8c3ad9b/output.txt

Total script time: 3.63 mins

  • Unit Tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://3.101.106.178:8877/71137b5ece5b049/output.txt

Total script time: 5.78 mins

  • Unit Tests: Passed

@brendandahl brendandahl merged commit 56fd01b into mozilla:master Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants