Use DOM hidden property instead of attribute methods

[nt1m]

.setAttribute("hidden", "true") or .setAttribute("hidden", true) are misleading, because .setAttribute("hidden", "false") also hides the element. This is because the HTML UA sheet matches [hidden].

.setAttribute("hidden", "hidden"); or .hidden = true would be correct ways to do it. The latter is more future-proof though.

The reason I'm doing this is because this showed up in the XUL boolean attribute matches in mozilla-central (XUL considers hidden=true as correct unlike HTML, and I'm looking into fixing that).

[timvandermeij]

/botio test

[pdfjsbot]

From: Bot.io (Linux m4)

---

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/efbcd9629553dfd/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://3.101.106.178:8877/c43f29b86600d32/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Failed

Full output at http://54.67.70.0:8877/efbcd9629553dfd/output.txt

Total script time: 23.10 mins

• Font tests: Passed
• Unit tests: FAILED
• Integration Tests: Passed
• Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/efbcd9629553dfd/reftest-analyzer.html#web=eq.log

[pdfjsbot]

From: Bot.io (Windows)

---

Failed

Full output at http://3.101.106.178:8877/c43f29b86600d32/output.txt

Total script time: 29.10 mins

• Font tests: Passed
• Unit tests: Passed
• Integration Tests: Passed
• Regression tests: FAILED

Image differences available at: http://3.101.106.178:8877/c43f29b86600d32/reftest-analyzer.html#web=eq.log

[timvandermeij]

/botio-linux preview

[pdfjsbot]

From: Bot.io (Linux m4)

---

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/1d0891e6d91f741/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.67.70.0:8877/1d0891e6d91f741/output.txt

Total script time: 4.21 mins

Published

• Viewer: http://54.67.70.0:8877/1d0891e6d91f741/web/viewer.html
• Viewer (ES5): http://54.67.70.0:8877/1d0891e6d91f741/es5/web/viewer.html

[timvandermeij]

Thank you for improving this!