Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the Stylelint shorthand-property-no-redundant-values rule #12888

Merged
merged 1 commit into from
Jan 22, 2021
Merged

Enable the Stylelint shorthand-property-no-redundant-values rule #12888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .stylelintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,6 @@
"length-zero-no-unit": [true, {
ignore: ["custom-properties"]
}],
"shorthand-property-no-redundant-values": true,
},
}
4 changes: 2 additions & 2 deletions web/pdf_viewer.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
direction: ltr;
width: 816px;
height: 1056px;
margin: 1px auto -8px auto;
margin: 1px auto -8px;
position: relative;
overflow: visible;
border: 9px solid transparent;
Expand All @@ -33,7 +33,7 @@
}

.pdfViewer.removePageBorders .page {
margin: 0 auto 10px auto;
margin: 0 auto 10px;
border: none;
}

Expand Down
22 changes: 11 additions & 11 deletions web/viewer.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,8 +456,8 @@ html[dir="rtl"] #outerContainer.sidebarOpen #loadingBar {
z-index: 10000;
height: auto;
min-width: 16px;
padding: 0 4px 0 4px;
margin: 4px 2px 4px 2px;
padding: 0 4px;
margin: 4px 2px;
color: rgba(217, 217, 217, 1);
font-size: 12px;
line-height: 14px;
Expand Down Expand Up @@ -571,7 +571,7 @@ html[dir="rtl"] #findInput[data-status="pending"] {
}

.secondaryToolbar {
padding: 6px 0 10px 0;
padding: 6px 0 10px;
height: auto;
z-index: 30000;
background-color: var(--doorhanger-bg-color);
Expand Down Expand Up @@ -1079,7 +1079,7 @@ html[dir="rtl"] .toolbarButton.pdfSidebarNotification::after {
.secondaryToolbarButton {
position: relative;
margin: 0;
padding: 0 0 1px 0;
padding: 0 0 1px;
height: auto;
min-height: 26px;
width: auto;
Expand Down Expand Up @@ -1185,15 +1185,15 @@ html[dir="rtl"] .verticalToolbarSeparator {

.horizontalToolbarSeparator {
display: block;
margin: 6px 0 5px 0;
margin: 6px 0 5px;
height: 1px;
width: 100%;
border-top: 1px solid var(--doorhanger-separator-color);
}

.toolbarField {
padding: 4px 7px;
margin: 3px 0 3px 0;
margin: 3px 0;
border-radius: 2px;
background-color: var(--field-bg-color);
background-clip: padding-box;
Expand Down Expand Up @@ -1281,7 +1281,7 @@ html[dir="rtl"] #numPages.toolbarLabel {
}

.thumbnail {
margin: 0 10px 5px 10px;
margin: 0 10px 5px;
}
html[dir="ltr"] .thumbnail {
float: left;
Expand All @@ -1300,7 +1300,7 @@ html[dir="rtl"] .thumbnail {

.thumbnail:not([data-loaded]) {
border: 1px dashed rgba(132, 132, 132, 1);
margin: -1px 9px 4px 9px;
margin: -1px 9px 4px;
}

.thumbnailImage {
Expand Down Expand Up @@ -1479,8 +1479,8 @@ html[dir="rtl"] .treeItemToggler::before {

.overlayButton {
width: auto;
margin: 3px 4px 2px 4px !important;
padding: 2px 11px 2px 11px;
margin: 3px 4px 2px !important;
padding: 2px 11px;
}

#overlayContainer {
Expand Down Expand Up @@ -1529,7 +1529,7 @@ html[dir="rtl"] .treeItemToggler::before {

.dialog .separator {
display: block;
margin: 4px 0 4px 0;
margin: 4px 0;
height: 1px;
width: 100%;
background-color: var(--separator-color);
Expand Down