-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace some ternary operators with optional chaining, and nullish coalescing, in the src/display/
-folder
#12875
Replace some ternary operators with optional chaining, and nullish coalescing, in the src/display/
-folder
#12875
Conversation
…alescing, in the `src/display/`-folder This way, we can further reduce unnecessary code-repetition in some cases.
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/073f1aa2657c031/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/594c27ed90649f9/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/594c27ed90649f9/output.txt Total script time: 26.46 mins
Image differences available at: http://54.67.70.0:8877/594c27ed90649f9/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/073f1aa2657c031/output.txt Total script time: 26.91 mins
Image differences available at: http://3.101.106.178:8877/073f1aa2657c031/reftest-analyzer.html#web=eq.log |
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/665414fd9ab86ac/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/bfaf5d504230730/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/665414fd9ab86ac/output.txt Total script time: 3.01 mins
|
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/bfaf5d504230730/output.txt Total script time: 4.07 mins
|
Given that PR #12874 has the same exact integration-test failure, and that PR only touches README-files, I don't think the failure is relevant here either. |
Thanks! |
This way, we can further reduce unnecessary code-repetition in some cases.