-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always re-measure non-embedded ArialNarrow fonts (bug 1671312, PR 12725 follow-up) #12861
Always re-measure non-embedded ArialNarrow fonts (bug 1671312, PR 12725 follow-up) #12861
Conversation
…25 follow-up) While PR 12725 fixed bug 1671312 as reported, i.e. the "In the upper right corner "Purposes' has bad kerning."-part, it however broke other parts of the text rendering. Note in particular the tables, e.g. on page 2 and beyond, where the glyphs are now rendered too close together. The reason for this is that the fonts in question are non-embedded ArialNarrow, which we just replace with Helvetica which obviously is not narrow. Given that the font replacement isn't a perfect fit for non-embedded ArialNarrow, we still need to re-measure the glyph widths in this case.
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/4db63905dfcc205/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/4db63905dfcc205/output.txt Total script time: 4.15 mins Published |
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/7b72d92ca5eda1c/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/2353e2d656920e7/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/2353e2d656920e7/output.txt Total script time: 26.38 mins
Image differences available at: http://54.67.70.0:8877/2353e2d656920e7/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/7b72d92ca5eda1c/output.txt Total script time: 28.78 mins
Image differences available at: http://3.101.106.178:8877/7b72d92ca5eda1c/reftest-analyzer.html#web=eq.log |
Thank you! /botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://3.101.106.178:8877/ed917f2d46274a6/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/9516191092f10d7/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/9516191092f10d7/output.txt Total script time: 24.50 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/ed917f2d46274a6/output.txt Total script time: 25.94 mins
|
While PR #12725 fixed bug 1671312 as reported, i.e. the "In the upper right corner "Purposes' has bad kerning."-part, it however broke other parts of the text rendering.
Note in particular the tables, e.g. on page 2 and beyond, where the glyphs are now rendered too close together. The reason for this is that the fonts in question are non-embedded ArialNarrow, which we just replace with Helvetica which obviously is not narrow. Given that the font replacement isn't a perfect fit for non-embedded ArialNarrow, we still need to re-measure the glyph widths in this case.