Correctly align annotation content in horizontal/spead scrolling modes #12848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/0cba2ba57984855/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/0cba2ba57984855/output.txt Total script time: 4.02 mins Published |
Snuffleupagus
approved these changes
Jan 10, 2021
Not only was long text in popups no longer wrapped correctly, the alignment was also center instead of left (or right, depending on the locale used) for both text in popups and the other parts within the annotation's section, such as the icon.
timvandermeij
changed the title
timvandermeij
force-pushed
the
annotation-horizontal
branch
from
d142276 to
36e6ae5
Compare
|
I have amended the commit message and PR title/text to also instead the spread modes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not only was long text in popups no longer wrapped correctly, the alignment was also center instead of left (or right, depending on the locale used) for both text in popups and the other parts within the annotation's section, such as the icon.
In order to test this, I made annotation-popup-long.pdf that, when opened with the current viewer, will show the issue when the horizontal/spread scrolling modes are used and when opened with the new viewer will no longer have this issue. I have checked the other files in the test suite as well to make sure that this works for all of them.
Fixes #12847.