Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS -- add support for choice widget #12826

Merged
merged 1 commit into from
Jan 25, 2021
Merged

JS -- add support for choice widget #12826

merged 1 commit into from
Jan 25, 2021

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman calixteman requested a review from brendandahl January 7, 2021 15:22
@calixteman
Copy link
Contributor Author

/botio integrationtest

@pdfjsbot
Copy link

pdfjsbot commented Jan 7, 2021

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/79d3b939ec4ecfc/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jan 7, 2021

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/79d3b939ec4ecfc/output.txt

Total script time: 2.98 mins

  • Integration Tests: Passed

@moos
Copy link

moos commented Jan 13, 2021

Just ran into this issue -- pdfjs does not handle setting multiple-choice select values in the annotationStorage. Thank you for this PR 💯 .

Using examples/mobile-viewer with test/pdfs/annotation-choice-widget.pdf I get:

PDFViewerApplication.pdfDocument.annotationStorage.getAll()
57R: {value: "Dolor"}
58R: {value: ""}
59R: {value: "Sit"}
62R: {value: "Ipsum"}
63R: {value: ""}

Dropdown "62R" (which has the multiple attribute) should have the four selected values: ["Ipsum", "Amit", "Consectetur", "Elit"], but it only has the first one.

brendandahl
brendandahl approved these changes Jan 25, 2021
View reviewed changes
test/integration/scripting_spec.js Outdated
for (const num of [2, 5]) {
--len;
await clearInput(page, "#\\33 9R");
await page.type("#\\33 9R", `${num}`, { delay: 10 });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the test require this delay or is it to mimic more of a real user?

@brendandahl
Copy link
Contributor

Needs a re-base too.

@calixteman
Copy link
Contributor Author

/botio integrationtest

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/76d0978f6b87c60/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://3.101.106.178:8877/1786c52bdc4e603/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/76d0978f6b87c60/output.txt

Total script time: 3.25 mins

  • Integration Tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)

Success

Full output at http://3.101.106.178:8877/1786c52bdc4e603/output.txt

Total script time: 4.18 mins

  • Integration Tests: Passed

@calixteman calixteman merged commit a3f6882 into mozilla:master Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus left review comments

@brendandahl brendandahl brendandahl approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@calixteman @pdfjsbot @moos @brendandahl @Snuffleupagus @timvandermeij