Improve the handling of errors, in PartialEvaluator.loadFont, occuring in PartialEvaluator.preEvaluateFont (issue 12823)
#12824
Conversation
…ing in `PartialEvaluator.preEvaluateFont` (issue 12823) Currently any errors thrown in `preEvaluateFont`, which is a *synchronous* method, will not be handled at all in the `loadFont` method and we were thus failing to return an `ErrorFont`-instance as intended here. Also, add an *explicit* check in `PartialEvaluator.preEvaluateFont` to ensure that Type0-fonts always have a *valid* dictionary.
Snuffleupagus
force-pushed
the
preEvaluateFont-errors
branch
from
6c0e421 to
78c32c2
Compare
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/e778f5e11d15691/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/9387a6c9268fcf3/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/9387a6c9268fcf3/output.txt Total script time: 26.00 mins
Image differences available at: http://54.67.70.0:8877/9387a6c9268fcf3/reftest-analyzer.html#web=eq.log |
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/d7d86692cda3eba/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/d7d86692cda3eba/output.txt Total script time: 4.06 mins Published |
|
Nice; thanks! /botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/0c53071d372fa35/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/0c53071d372fa35/output.txt Total script time: 24.43 mins
|
|
/botio-windows makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @brendandahl received. Current queue size: 0 Live output at: http://3.101.106.178:8877/26f04cafbbdf93c/output.txt |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/26f04cafbbdf93c/output.txt Total script time: 0.29 mins |
|
/botio-windows makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/26893c228ff0cd9/output.txt |
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/26893c228ff0cd9/output.txt Total script time: 25.86 mins
|
Currently any errors thrown in
preEvaluateFont, which is a synchronous method, will not be handled at all in theloadFontmethod and we were thus failing to return anErrorFont-instance as intended here.Also, add an explicit check in
PartialEvaluator.preEvaluateFontto ensure that Type0-fonts always have a valid dictionary.Fixes #12823