Improve the PDFViewerApplication._contentLength handling in the viewer, related mostly to scripting
#12822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wer, related mostly to scripting Ensure that `PDFViewerApplication._contentLength` is always updated with the *correct* length, as returned by `PDFDocumentProxy.getDownloadInfo`, and only let the `PDFViewerApplication._initializeMetadata` method overwrite if it's not already been set. Finally, in `PDFViewerApplication._initializeJavaScript`, the fallback `_contentLength` handling is now moved to just after the fallback `documentInfo` handling, such that all the fallback code is in one place within the method.
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/414387c151bd820/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/e0e43155b157b73/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/414387c151bd820/output.txt Total script time: 2.78 mins
|
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/e0e43155b157b73/output.txt Total script time: 3.70 mins
|
timvandermeij
approved these changes
Jan 7, 2021
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that
PDFViewerApplication._contentLengthis always updated with the correct length, as returned byPDFDocumentProxy.getDownloadInfo, and only let thePDFViewerApplication._initializeMetadatamethod overwrite if it's not already been set.Finally, in
PDFViewerApplication._initializeJavaScript, the fallback_contentLengthhandling is now moved to just after the fallbackdocumentInfohandling, such that all the fallback code is in one place within the method.