Remove the DownloadManager.onerror functionality, since its only usage is unlikely to be helpful
#12804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…document filename Currently this code is duplicated no less than three times in the `web/app.js` file, and by introducing a helper method we can avoid unnecessary repetition.
…age is unlikely to be helpful Note how the `onerror` functionality is not being used in the GENERIC `DownloadManager`, since we have no way of knowing if downloading succeeded. Hence this functionality is only *possibly* useful in MOZCENTRAL builds, however as outlined in the existing comments it's unlikely to be helpful in practice. Generally speaking, if downloading failed once in [`PdfStreamConverter.jsm`](https://searchfox.org/mozilla-central/rev/809ac3660845fef6faf18ec210232fdadc0f1ad9/toolkit/components/pdfjs/content/PdfStreamConverter.jsm#294-406) it seems very likely that it would fail again; all-in-all I'm thus suggesting that we just remove the `onerror` functionality altogether here.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/82cfc14509e1879/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/82cfc14509e1879/output.txt Total script time: 4.04 mins Published |
timvandermeij
approved these changes
Jan 3, 2021
|
Nice, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new helper method, on
PDFViewerApplication, to determine the document filenameCurrently this code is duplicated no less than three times in the
web/app.jsfile, and by introducing a helper method we can avoid unnecessary repetition.Remove the
DownloadManager.onerrorfunctionality, since its only usage is unlikely to be helpfulNote how the
onerrorfunctionality is not being used in the GENERICDownloadManager, since we have no way of knowing if downloading succeeded.Hence this functionality is only possibly useful in MOZCENTRAL builds, however as outlined in the existing comments it's unlikely to be helpful in practice. Generally speaking, if downloading failed once in
PdfStreamConverter.jsmit seems very likely that it would fail again; all-in-all I'm thus suggesting that we just remove theonerrorfunctionality altogether here.