Include the state in the "presentationmodechanged" event, and remove the separate active/switchInProgress properties
#12788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio-windows preview |
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/f2e18570b9fed79/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/f2e18570b9fed79/output.txt Total script time: 4.14 mins Published |
…e the separate `active`/`switchInProgress` properties Given that we already have a `PresentationModeState`-enumeration, we should use that with the "presentationmodechanged" event rather than including separate properties. Note that this new behaviour, of including an enumeration-value in the event, is consistent with lots of other existing viewer-events. To hopefully avoid issues in custom implementations of the default viewer, any attempt to access the removed properties will now throw.
Snuffleupagus
force-pushed
the
presentationmodechanged-state
branch
from
f3e31a7 to
c185061
Compare
timvandermeij
approved these changes
Dec 28, 2020
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that we already have a
PresentationModeState-enumeration, we should use that with the "presentationmodechanged" event rather than including separate properties. Note that this new behaviour, of including an enumeration-value in the event, is consistent with lots of other existing viewer-events.To hopefully avoid issues in custom implementations of the default viewer, any attempt to access the removed properties will now throw.