JS -- Add tests for print/save actions #12774
Conversation
calixteman
commented
Dec 23, 2020
•
calixteman
commented
- change PDFDocument::hasJSActions to return true when there are JS actions in catalog.
calixteman
force-pushed
the
doc_action_test
branch
2 times, most recently
from
53ab319 to
272a609
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.67.70.0:8877/9b52e6bcbb671f4/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://3.101.106.178:8877/76720f26142c0c0/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/9b52e6bcbb671f4/output.txt Total script time: 26.30 mins
Image differences available at: http://54.67.70.0:8877/9b52e6bcbb671f4/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/76720f26142c0c0/output.txt Total script time: 27.89 mins
Image differences available at: http://3.101.106.178:8877/76720f26142c0c0/reftest-analyzer.html#web=eq.log |
calixteman
force-pushed
the
doc_action_test
branch
from
272a609 to
1245002
Compare
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://3.101.106.178:8877/7b6f0a940f1975d/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.67.70.0:8877/676757ffcd1c45a/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/676757ffcd1c45a/output.txt Total script time: 26.50 mins
Image differences available at: http://54.67.70.0:8877/676757ffcd1c45a/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/7b6f0a940f1975d/output.txt Total script time: 27.96 mins
Image differences available at: http://3.101.106.178:8877/7b6f0a940f1975d/reftest-analyzer.html#web=eq.log |
calixteman
force-pushed
the
doc_action_test
branch
from
1245002 to
8fb0032
Compare
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.67.70.0:8877/ee732672993253c/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://3.101.106.178:8877/acbf95987daaaa1/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/ee732672993253c/output.txt Total script time: 2.88 mins
|
* change PDFDocument::hasJSActions to return true when there are JS actions in catalog.
calixteman
force-pushed
the
doc_action_test
branch
from
8fb0032 to
ffd4bc7
Compare
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.67.70.0:8877/5b7f2e5f5a1227e/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/5b7f2e5f5a1227e/output.txt Total script time: 2.92 mins
|
|
Thank you for extending the test coverage! |
| // Doesn't work because of bug 1662471 | ||
| return; |
There was a problem hiding this comment.
Sorry, I just noticed this now and that's really not how you temporarily disable a test, since that pretty much guarantees that no one will ever fix it.
The correct way, since we're using Jasmine, is to add a pending() statement; i.e.
pending("Disabled in Firefox on Windows, because of bug 1662471.");
There was a problem hiding this comment.
Good point, I also missed this one. @calixteman Let's address this one in a follow-up PR.
