Add new "pageopen"/"pageclose" events for usage with JavaScript actions #12747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having looked at the Acrobat JavaScript specification, see https://www.adobe.com/content/dam/acom/en/devnet/acrobat/pdfs/AcrobatDC_js_api_reference.pdf#G5.1963437, I suppose that introducing these two new events is probably the easiest solution overall. However there's a number of things that, as far as I'm concerned, will help the overall implementation: - Only dispatch these new events when `enableScripting = true` is set. - Handle them *separately* from the existing "pagechanging" event dispatching, to avoid too much clutter. - Don't dispatch either of the events if the page didn't actually change. - When waiting for pages to render, don't dispatch "pageopen" if the page is no longer active when rendering finishes. - Ensure that we only use *one* "pagerendered" event listener. - Ensure that "pageopen" is actually dispatched when the document loads. I suppose that we *could* avoid adding the "pageclose" event, and use the existing "pagechanging" event instead, however having a separate event might allow more flexibility in the future. (E.g. I don't know if we'll possibly want to dispatch "pageclose" on document close, as mentioned briefly in the specification.)
…removes an existing document This new event essentially mirrors the existing "pagesinit" event, and will allow e.g. a custom implementation of the viewer to be notified before the current PDF document is removed from the viewer. By using this new event, we're thus able to dispatch a "pageclose" event for JavaScript actions when closing the existing document.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/52c1fc1f4b5820e/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/52c1fc1f4b5820e/output.txt Total script time: 4.19 mins Published |
calixteman
approved these changes
Dec 17, 2020
timvandermeij
approved these changes
Dec 18, 2020
|
Looks like a good solution to me too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to the individual commit messages for additional information.
https://www.adobe.com/content/dam/acom/en/devnet/acrobat/pdfs/AcrobatDC_js_api_reference.pdf#G5.1963437
@timvandermeij I really hoped to be able to use e.g. the existing "pagechanging" events, but based on the requirements outlined in the specification I just don't see a better way than adding new events here; please let me know if you have a better idea!