[gulpfile.js] Move the time-zone hack to the testing-pre task, such that *all* tests work regardless of the current time-zone
#12728
Conversation
… that *all* tests work regardless of the current time-zone Currently only the `gulp unittest` task actually set the time-zone, which means that locally I'm now getting failures with e.g. `gulp test`. *Please note:* I firmly believe that the unit-tests in question should be re-written, since even with this patch applied there's failures when running http://localhost:8888/test/unit/unit_test.html directly in a browser.
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/2a8de97cc0ada7c/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/25a65f6bd98baab/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/2a8de97cc0ada7c/output.txt Total script time: 3.60 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/25a65f6bd98baab/output.txt Total script time: 4.67 mins
|
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/abae0f2a285f1bb/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/886c0baf7c9dc27/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/abae0f2a285f1bb/output.txt Total script time: 2.29 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/886c0baf7c9dc27/output.txt Total script time: 3.30 mins
|
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/ae2cf7632f5f349/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/aabe5a0f8e43da3/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/ae2cf7632f5f349/output.txt Total script time: 25.74 mins
Image differences available at: http://54.67.70.0:8877/ae2cf7632f5f349/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/aabe5a0f8e43da3/output.txt Total script time: 30.99 mins
Image differences available at: http://3.101.106.178:8877/aabe5a0f8e43da3/reftest-analyzer.html#web=eq.log |
|
Thanks! |
Currently only the
gulp unittesttask actually set the time-zone, which means that locally I'm now getting failures with e.g.gulp test.Please note: I firmly believe that the unit-tests in question should be re-written, since even with this patch applied there's failures when running http://localhost:8888/test/unit/unit_test.html directly in a browser.