Fix non-standard quadpoints orders for annotations #12696
Conversation
…onElement` class Using an object for the various constructor options makes extensions easier and makes the code self-documenting.
…ement` class Doing so avoids some code duplication.
… class Not only does this reduce boilerplate since the documentation is the same for all annotation classes, it also wasn't correct for the annotation types that support quadpoints since they return an array of section elements instead of a single one.
Each quadrilateral needs to have its own link element, so the first quadrilateral can use the already created element, but the next quadrilaterals need to clone that element.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/f6172955f75f14c/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/f6172955f75f14c/output.txt Total script time: 4.09 mins Published |
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/d2e207446046055/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://3.101.106.178:8877/6cf102762f8be5a/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/d2e207446046055/output.txt Total script time: 25.53 mins
Image differences available at: http://54.67.70.0:8877/d2e207446046055/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/6cf102762f8be5a/output.txt Total script time: 29.83 mins
Image differences available at: http://3.101.106.178:8877/6cf102762f8be5a/reftest-analyzer.html#web=eq.log |
This change requires us to use valid quadpoints arrays in the existing unit tests too due to the normalization.
timvandermeij
force-pushed
the
annotation-quadpoints
branch
from
121863f to
012e15f
Compare
|
/botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://3.101.106.178:8877/28e18832707f6cf/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/7e5ad2c26aeff99/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/7e5ad2c26aeff99/output.txt Total script time: 24.87 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/28e18832707f6cf/output.txt Total script time: 29.19 mins
|
The commit messages contain more information about the individual changes.
Fixes #12675.
Fixes #6811.