Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some integration tests using puppeteer #12668

Merged
merged 1 commit into from
Dec 10, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 64 additions & 21 deletions gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ const DEFINES = Object.freeze({
PRODUCTION: true,
SKIP_BABEL: true,
TESTING: false,
ENABLE_SCRIPTING: false,
// The main build targets:
GENERIC: false,
MOZCENTRAL: false,
Expand Down Expand Up @@ -303,14 +304,26 @@ function checkChromePreferencesFile(chromePrefsPath, webPrefsPath) {
return false;
}
if (webPrefsKeys.length !== chromePrefsKeys.length) {
console.log("Warning: Prefs objects haven't the same length");
return false;
}
return webPrefsKeys.every(function (value, index) {
return (
chromePrefsKeys[index] === value &&
chromePrefs.properties[value].default === webPrefs[value]
);
});

let ret = true;
for (let i = 0, ii = webPrefsKeys.length; i < ii; i++) {
const value = webPrefsKeys[i];
if (chromePrefsKeys[i] !== value) {
ret = false;
console.log(
`Warning: not the same keys: ${chromePrefsKeys[i]} !== ${value}`
);
} else if (chromePrefs.properties[value].default !== webPrefs[value]) {
ret = false;
console.log(
`Warning: not the same values: ${chromePrefs.properties[value].default} !== ${webPrefs[value]}`
);
}
}
return ret;
}

function replaceWebpackRequire() {
Expand Down Expand Up @@ -515,6 +528,9 @@ function createTestSource(testsName, bot) {
case "font":
args.push("--fontTest");
break;
case "integration":
args.push("--integration");
break;
default:
this.emit("error", new Error("Unknown name: " + testsName));
return null;
Expand Down Expand Up @@ -646,6 +662,7 @@ gulp.task("default_preferences-pre", function () {
LIB: true,
BUNDLE_VERSION: 0, // Dummy version
BUNDLE_BUILD: 0, // Dummy build
ENABLE_SCRIPTING: process.env.ENABLE_SCRIPTING === "true",
}),
map: {
"pdfjs-lib": "../pdf",
Expand Down Expand Up @@ -1507,27 +1524,46 @@ gulp.task("testing-pre", function (done) {
done();
});

gulp.task("enable-scripting", function (done) {
process.env.ENABLE_SCRIPTING = "true";
done();
});

gulp.task(
"test",
gulp.series("testing-pre", "generic", "components", function () {
return streamqueue(
{ objectMode: true },
createTestSource("unit"),
createTestSource("browser")
);
})
gulp.series(
"enable-scripting",
"testing-pre",
"generic",
"components",
function () {
return streamqueue(
{ objectMode: true },
createTestSource("unit"),
createTestSource("browser"),
createTestSource("integration")
);
}
)
);

gulp.task(
"bottest",
gulp.series("testing-pre", "generic", "components", function () {
return streamqueue(
{ objectMode: true },
createTestSource("unit", true),
createTestSource("font", true),
createTestSource("browser (no reftest)", true)
);
})
gulp.series(
"enable-scripting",
"testing-pre",
"generic",
"components",
function () {
return streamqueue(
{ objectMode: true },
createTestSource("unit", true),
createTestSource("font", true),
createTestSource("browser (no reftest)", true),
createTestSource("integration")
);
}
)
);

gulp.task(
Expand All @@ -1545,6 +1581,13 @@ gulp.task(
})
);

gulp.task(
"integrationtest",
gulp.series("enable-scripting", "testing-pre", "generic", function () {
return createTestSource("integration");
})
);

gulp.task(
"fonttest",
gulp.series("testing-pre", function () {
Expand Down
53 changes: 53 additions & 0 deletions test/integration-boot.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
/* Copyright 2020 Mozilla Foundation
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

"use strict";

const Jasmine = require("jasmine");

async function runTests(results) {
const jasmine = new Jasmine();
jasmine.jasmine.DEFAULT_TIMEOUT_INTERVAL = 30000;

jasmine.loadConfig({
random: false,
spec_dir: "integration",
spec_files: ["scripting_spec.js", "annotation_spec.js"],
});

jasmine.addReporter({
jasmineDone(suiteInfo) {},
jasmineStarted(suiteInfo) {},
specDone(result) {
++results.runs;
if (result.failedExpectations.length > 0) {
++results.failures;
console.log(`TEST-UNEXPECTED-FAIL | ${result.description}`);
} else {
console.log(`TEST-PASSED | ${result.description}`);
}
},
specStarted(result) {},
suiteDone(result) {},
suiteStarted(result) {},
});

return new Promise(resolve => {
jasmine.onComplete(resolve);
jasmine.execute();
});
}

exports.runTests = runTests;
63 changes: 63 additions & 0 deletions test/integration/annotation_spec.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
/* Copyright 2020 Mozilla Foundation
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

describe("Annotation highlight", () => {
describe("annotation-highlight.pdf", () => {
let pages;

beforeAll(async () => {
pages = await Promise.all(
global.integrationSessions.map(async session => {
const page = await session.browser.newPage();
await page.goto(
`${global.integrationBaseUrl}?file=/test/pdfs/annotation-highlight.pdf`
);
await page.bringToFront();
await page.waitForSelector("[data-annotation-id='19R']", {
timeout: 0,
});
return page;
})
);
});

afterAll(async () => {
await Promise.all(
pages.map(async page => {
await page.close();
})
);
});

it("must show a popup on mouseover", async () => {
await Promise.all(
pages.map(async page => {
let hidden = await page.$eval(
"[data-annotation-id='21R']",
el => el.hidden
);
expect(hidden).toEqual(true);
await page.hover("[data-annotation-id='19R']");
await page.waitForTimeout(100);
hidden = await page.$eval(
"[data-annotation-id='21R']",
el => el.hidden
);
expect(hidden).toEqual(false);
})
);
});
});
});
66 changes: 66 additions & 0 deletions test/integration/scripting_spec.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
/* Copyright 2020 Mozilla Foundation
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

describe("Interaction", () => {
describe("in 160F-2019.pdf", () => {
let pages;

beforeAll(async () => {
pages = await Promise.all(
global.integrationSessions.map(async session => {
const page = await session.browser.newPage();
await page.goto(
`${global.integrationBaseUrl}?file=/test/pdfs/160F-2019.pdf`
);
await page.bringToFront();
await page.waitForSelector("#\\34 16R", {
timeout: 0,
});
return [session.name, page];
})
);
});

afterAll(async () => {
await Promise.all(
pages.map(async ([_, page]) => {
await page.close();
})
);
});

it("must format the field with 2 digits and leave field with a click", async () => {
await Promise.all(
pages.map(async ([name, page]) => {
await page.type("#\\34 16R", "3.14159", { delay: 200 });
await page.click("#\\34 19R");
const text = await page.$eval("#\\34 16R", el => el.value);
expect(text).withContext(`In ${name}`).toEqual("3,14");
})
);
});

it("must format the field with 2 digits and leave field with a TAB", async () => {
await Promise.all(
pages.map(async ([name, page]) => {
await page.type("#\\34 22R", "2.7182818", { delay: 200 });
await page.keyboard.press("Tab");
const text = await page.$eval("#\\34 22R", el => el.value);
expect(text).withContext(`In ${name}`).toEqual("2,72");
})
);
});
});
});
Loading