JS -- Add support for buttons #12637
Conversation
calixteman
commented
Nov 18, 2020
calixteman
commented
- radio buttons
- checkboxes
|
Needs a rebase. Did a quick test with it rebased and radio buttons are working as expected, but radio checkboxes are not. http://www.windjack.com/DownLoads/RadioCheckBox_AcroForm.pdf Would be good if we could get the puppeteer testing added, so then we can add tests for this first. |
|
The radio checkboxes have no JS here so there is a bug in |
|
Can we add a test for this code now too? |
calixteman
force-pushed
the
buttons
branch
3 times, most recently
from
9327208 to
56e75e9
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.67.70.0:8877/052546f2f539dba/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://3.101.106.178:8877/e7ce2fa013a06a5/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/052546f2f539dba/output.txt Total script time: 26.05 mins
Image differences available at: http://54.67.70.0:8877/052546f2f539dba/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/e7ce2fa013a06a5/output.txt Total script time: 27.29 mins
Image differences available at: http://3.101.106.178:8877/e7ce2fa013a06a5/reftest-analyzer.html#web=eq.log |
test/integration/scripting_spec.js
Outdated
| await page.waitForTimeout(100); | ||
| for (const [selector, expectedText] of expected) { | ||
| await page.click(selector); | ||
| await page.waitForTimeout(100); |
There was a problem hiding this comment.
As we've seen in other tests, using timeouts is a big cause of intermittent failures. Can we add an annotationchanged event or something instead?
test/integration/scripting_spec.js
Outdated
| ["#\\37 0R", "Group1=Choice3::3"], | ||
| ["#\\37 1R", "Group1=Choice4::4"], | ||
| ]; | ||
| await page.waitForTimeout(100); |
There was a problem hiding this comment.
Same here, why is this timeout needed is there an event that can be used instead?
* radio buttons * checkboxes
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://54.67.70.0:8877/6e734e79167c92f/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://3.101.106.178:8877/142a9f7c94d46d5/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/6e734e79167c92f/output.txt Total script time: 26.25 mins
Image differences available at: http://54.67.70.0:8877/6e734e79167c92f/reftest-analyzer.html#web=eq.log |
|
/botio-windows test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://3.101.106.178:8877/1a68320d5cc5f8d/output.txt |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/1a68320d5cc5f8d/output.txt Total script time: 28.49 mins
Image differences available at: http://3.101.106.178:8877/1a68320d5cc5f8d/reftest-analyzer.html#web=eq.log |
|
/botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @brendandahl received. Current queue size: 0 Live output at: http://3.101.106.178:8877/9ba6b09283678ac/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @brendandahl received. Current queue size: 0 Live output at: http://54.67.70.0:8877/f2ab1e354d865f5/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/f2ab1e354d865f5/output.txt Total script time: 24.41 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/9ba6b09283678ac/output.txt Total script time: 25.51 mins
|
