Modernize, and remove SystemJS usage from, the font-tests #12532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From: Bot.io (Linux m4)ReceivedCommand cmd_fonttest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/3a4c2a835ae760d/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/3a4c2a835ae760d/output.txt Total script time: 1.78 mins
|
This patch first of all enables linting of the files in the `test/font/` folder, and secondly it also re-factors all test files to use native `import`/`export` statements. Finally, all tests are now loaded correctly, rather than being included as scripts through the `font_test.html` file.
This was done automatically, using the `gulp lint --fix` command.
With these changes, SystemJS is now *only* used to load the worker-file in development mode (pending removal once https://bugzilla.mozilla.org/show_bug.cgi?id=1247687 is fixed).
Snuffleupagus
force-pushed
the
refactor-font-tests
branch
from
5f7ec35 to
939af08
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_fonttest from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.67.70.0:8877/6dcfbbba521f31b/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/6dcfbbba521f31b/output.txt Total script time: 1.76 mins
|
timvandermeij
approved these changes
Oct 26, 2020
|
Thank you for doing this! Much nicer without those global exports as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to the individual commit messages for additional information.
With these changes, SystemJS is now only used to load the worker-file in development mode (pending removal once https://bugzilla.mozilla.org/show_bug.cgi?id=1247687 is fixed).