Improve argument/name handling when parsing TilingPatterns (PR 12458 follow-up) #12526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…follow-up) - Handle the arguments correctly in `PartialEvaluator.handleColorN`. For TilingPatterns with a base-ColorSpace, we're currently using the `args` when computing the color. However, as can be seen we're passing the Array as-is to the `ColorSpace.getRgb` method, which means that the `Name` is included as well.[1] Thankfully this hasn't, as far as I know, caused any actual bugs, but that may be more luck than anything else given how the `ColorSpace` code is implemented. This can be easily fixed though, simply by popping the `Name`-object off of the `args` Array. - Cache TilingPatterns using the `Name`-string, rather than the object directly. This is not only consistent with other caches in `PartialEvaluator`, but importantly it also ensures that the cache lookup always works correctly. Note that since `Name`-objects, similar to other primitives, uses a cache themselves a *manually* triggered `cleanup`-call could thus (theoretically) cause the `LocalTilingPatternCache` to not find an existing entry. While the likelihood of this happening is *extremely* small, it's still something that we should fix. --- [1] The `args` Array can e.g. look like this: `[0.043, 0.09, 0.188, 0.004, /P1]`, which means that we're passing in the `Name`-object to the `ColorSpace` method.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/d2d99468066ebfe/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/d2d99468066ebfe/output.txt Total script time: 25.67 mins
Image differences available at: http://54.67.70.0:8877/d2d99468066ebfe/reftest-analyzer.html#web=eq.log |
timvandermeij
approved these changes
Oct 24, 2020
|
Thank you! I'm also a bit surprised that this didn't break anything we know of, so I guess we were lucky. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle the arguments correctly in
PartialEvaluator.handleColorN.For TilingPatterns with a base-ColorSpace, we're currently using the
argswhen computing the color. However, as can be seen we're passing the Array as-is to theColorSpace.getRgbmethod, which means that theNameis included as well.[1]Thankfully this hasn't, as far as I know, caused any actual bugs, but that may be more luck than anything else given how the
ColorSpacecode is implemented. This can be easily fixed though, simply by popping theName-object off of theargsArray.Cache TilingPatterns using the
Name-string, rather than the object directly.This is not only consistent with other caches in
PartialEvaluator, but importantly it also ensures that the cache lookup always works correctly. Note that sinceName-objects, similar to other primitives, uses a cache themselves a manually triggeredcleanup-call could thus (theoretically) cause theLocalTilingPatternCacheto not find an existing entry. While the likelihood of this happening is extremely small, it's still something that we should fix.[1] The
argsArray can e.g. look like this:[0.043, 0.09, 0.188, 0.004, /P1], which means that we're passing in theName-object to theColorSpacemethod.