[api-minor] Implement API to get MarkInfo from the catalog.

[brendandahl]

Trying to get more data so we can decide whether to implement tagged pdfs.

[timvandermeij]

Looks good with these comments addressed. I think the requestIdleCallback usage is quite a nice solution here!

[timvandermeij]

Looks good and can be merged with the final comment addressed!

[timvandermeij]

null -> false

[timvandermeij]

/botio unittest

[pdfjsbot]

From: Bot.io (Linux m4)

---

Received

Command cmd_unittest from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/21120e56b479603/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Failed

Full output at http://54.67.70.0:8877/21120e56b479603/output.txt

Total script time: 3.55 mins

• Unit Tests: FAILED

[timvandermeij]

TEST-UNEXPECTED-FAIL | gets markInfo | in firefox | Expected undefined to equal false. Expected undefined to equal false.
TEST-UNEXPECTED-FAIL | gets markInfo | in chrome | Expected undefined to equal false. Expected undefined to equal false.

Ah, it seems that Object.create creates an empty object instead of the prefilled one (tried in the web console). I think you can simply remove Object.create here:

const markInfo = {
  Marked: false,
  UserProperties: false,
  Suspects: false,
};

Not sure why Travis does like it. Maybe it does work in Node.js?

[Snuffleupagus]

Ah, it seems that Object.create creates an empty object instead of the prefilled one (tried in the web console).

The argument is used as the prototype, which doesn't survive the structured cloning algorithm.
If you actually want a null prototype, which I assume is indeed the case here, then the following is probably the way to go:

const markInfo = Object.assign(Object.create(null), {
  Marked: false,
  UserProperties: false,
  Suspects: false,
});

Not sure why Travis does like it. Maybe it does work in Node.js?

Probably because those tests run with workers disabled.

[timvandermeij]

/botio unittest

[pdfjsbot]

From: Bot.io (Linux m4)

---

Received

Command cmd_unittest from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/e8b9171fdff5716/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_unittest from @timvandermeij received. Current queue size: 0

Live output at: http://3.101.106.178:8877/abf377e340e41f8/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.67.70.0:8877/e8b9171fdff5716/output.txt

Total script time: 3.50 mins

• Unit Tests: Passed

[pdfjsbot]

From: Bot.io (Windows)

---

Success

Full output at http://3.101.106.178:8877/abf377e340e41f8/output.txt

Total script time: 4.61 mins

• Unit Tests: Passed

[timvandermeij]

/botio-linux preview

[pdfjsbot]

From: Bot.io (Linux m4)

---

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/620a8eba477c68d/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.67.70.0:8877/620a8eba477c68d/output.txt

Total script time: 3.99 mins

Published

• Viewer: http://54.67.70.0:8877/620a8eba477c68d/web/viewer.html
• Viewer (ES5): http://54.67.70.0:8877/620a8eba477c68d/es5/web/viewer.html

[timvandermeij]

Thanks!