Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback font for buttons must be ZapfDingbats. #12508

Merged
merged 1 commit into from
Oct 24, 2020

Conversation

calixteman
Copy link
Contributor

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like the kind of patch where you probably want to add an eq test as well, in addition to any unit-tests, since those are much more difficult to accidentally regress with any future changes.

@calixteman calixteman force-pushed the button_fallback_font branch from cd24a1e to 5ca7ac9 Compare October 23, 2020 09:51
@calixteman calixteman force-pushed the button_fallback_font branch from 5ca7ac9 to 37c86b2 Compare October 24, 2020 10:00
@timvandermeij
Copy link
Contributor

/botio-linux test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/5c4fff628e6ecd3/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/5c4fff628e6ecd3/output.txt

Total script time: 25.66 mins

  • Font tests: Passed
  • Unit tests: FAILED
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/5c4fff628e6ecd3/reftest-analyzer.html#web=eq.log

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/1c30fcefae93a41/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/1c30fcefae93a41/output.txt

Total script time: 3.94 mins

Published

@timvandermeij timvandermeij merged commit b4ca3d5 into mozilla:master Oct 24, 2020
@timvandermeij
Copy link
Contributor

Looks good; thanks!

/botio-linux makeref

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/ed9ca45c6386820/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/ed9ca45c6386820/output.txt

Total script time: 23.73 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@calixteman calixteman deleted the button_fallback_font branch November 3, 2020 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants