-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fallback font for buttons must be ZapfDingbats. #12508
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like the kind of patch where you probably want to add an eq
test as well, in addition to any unit-tests, since those are much more difficult to accidentally regress with any future changes.
76df144
to
cd24a1e
Compare
cd24a1e
to
5ca7ac9
Compare
5ca7ac9
to
37c86b2
Compare
/botio-linux test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/5c4fff628e6ecd3/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/5c4fff628e6ecd3/output.txt Total script time: 25.66 mins
Image differences available at: http://54.67.70.0:8877/5c4fff628e6ecd3/reftest-analyzer.html#web=eq.log |
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/1c30fcefae93a41/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/1c30fcefae93a41/output.txt Total script time: 3.94 mins Published |
Looks good; thanks! /botio-linux makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/ed9ca45c6386820/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/ed9ca45c6386820/output.txt Total script time: 23.73 mins
|
Fix bug https://bugzilla.mozilla.org/show_bug.cgi?id=1669099.