Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api-minor] JS - Add a function in api to get the fields ids in AcroForm::CO #12485

Merged
merged 1 commit into from
Oct 17, 2020

Conversation

calixteman
Copy link
Contributor

Each time a Field is validate then some Calculate actions may be ran just after.
In order to know in which order these actions are ran we must get this information from AcroForm::CO.
See the top of page 365 (and bottom of 364 of course):
https://www.adobe.com/content/dam/acom/en/devnet/acrobat/pdfs/js_api_reference.pdf#page=365

@timvandermeij timvandermeij changed the title JS - Add a function in api to get the fields ids in AcroForm::CO [api-minor] JS - Add a function in api to get the fields ids in AcroForm::CO Oct 16, 2020
Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with these two comments addressed. Thank you for making this PR small so it's easier to oversee and we can iterate faster.

src/display/api.js Show resolved Hide resolved
src/core/document.js Show resolved Hide resolved
@timvandermeij
Copy link
Contributor

/botio unittest

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_unittest from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/55519191a18f50b/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_unittest from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/922b2f0f4ccb6ac/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/55519191a18f50b/output.txt

Total script time: 4.26 mins

  • Unit Tests: FAILED

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/922b2f0f4ccb6ac/output.txt

Total script time: 5.51 mins

  • Unit Tests: Passed

@timvandermeij timvandermeij merged commit 3fa3cb6 into mozilla:master Oct 17, 2020
@timvandermeij
Copy link
Contributor

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants