-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade webpack
to version 5
#12470
Upgrade webpack
to version 5
#12470
Conversation
The only noticeable changes are that the built files are now *slightly* smaller, and that Webpack now supports optional chaining and nullish coalescing without the need for Babel plugins.
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/ab29cc2b2ae209d/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/068a8e7a871cf11/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/ab29cc2b2ae209d/output.txt Total script time: 26.10 mins
Image differences available at: http://54.67.70.0:8877/ab29cc2b2ae209d/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/068a8e7a871cf11/output.txt Total script time: 30.28 mins
Image differences available at: http://54.215.176.217:8877/068a8e7a871cf11/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/cbdc864019007f0/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/cbdc864019007f0/output.txt Total script time: 4.00 mins Published |
…`AppOptions` in `web/viewer` Given that we're no longer using SystemJS to load the `web/` files, see PR 11919, there's nothing that prevents us from using standard `ìmport` statements in this file. Obviously it's still necessary to load part of the code conditionally on the build type, however this still allows us to clean-up and simplify at least some of this file.
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/a86c7579b0a5b59/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/a86c7579b0a5b59/output.txt Total script time: 3.87 mins Published |
Nice, slightly smaller files and fewer direct dependencies. Thanks! |
The only noticeable changes are that the built files are now slightly smaller, and that Webpack now supports optional chaining and nullish coalescing without the need for Babel plugins.