-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade acorn
to version 8
#12451
Upgrade acorn
to version 8
#12451
Conversation
I've run `gulp mozcentral`, `gulp generic`, and `gulp generic-es5` with `master` respectively this patch and then diffed the build output. With the (obvious) exception of increased version/build numbers, there were no actual changes from the updated Acorn version.
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/9ba1c0e6e1e73e7/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/9ba1c0e6e1e73e7/output.txt Total script time: 3.53 mins Published |
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/a8487082aecf65a/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/8a66167c099a4bd/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/a8487082aecf65a/output.txt Total script time: 25.37 mins
Image differences available at: http://54.67.70.0:8877/a8487082aecf65a/reftest-analyzer.html#web=eq.log |
locations: true, | ||
sourceFile: ctx.sourceFile, | ||
sourceType: "module", | ||
}; | ||
var codegenOptions = { | ||
format: format, | ||
parse: acorn.parse, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, this was the part I missed when I fiddled with this before...
Thanks! |
I've run
gulp mozcentral
,gulp generic
, andgulp generic-es5
withmaster
respectively this patch and then diffed the build output. With the (obvious) exception of increased version/build numbers, there were no actual changes from the updated Acorn version.